fix(executor): conditional deactivation for loops/parallels#3069
Merged
fix(executor): conditional deactivation for loops/parallels#3069
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
Greptile OverviewGreptile SummaryFixed a bug in edge deactivation logic where nodes after loops/parallels were not properly deactivated when a conditional branch containing those control structures was not taken. Key Changes:
Test Coverage:
The fix is minimal, well-targeted, and backed by thorough test coverage. Confidence Score: 4/5
Important Files Changed
Sequence DiagramsequenceDiagram
participant Condition
participant SentinelStart as Sentinel Start
participant LoopBody as Loop Body
participant SentinelEnd as Sentinel End
participant AfterLoop as After Loop
participant OtherBranch as Other Branch
Note over Condition: Processing outgoing edges<br/>selectedOption: "else"
Condition->>SentinelStart: condition-if (not activated)
Condition->>OtherBranch: condition-else (activated)
Note over Condition,AfterLoop: Deactivation cascade begins
Condition--xSentinelStart: Deactivate edge
SentinelStart--xLoopBody: Cascade deactivation
LoopBody--xSentinelEnd: Cascade deactivation
Note over SentinelEnd: OLD: isControlEdge skipped loop_exit<br/>NEW: isBackwardsEdge allows loop_exit
SentinelEnd--xAfterLoop: Deactivate loop_exit edge (FIX)
Note over AfterLoop: All incoming edges deactivated<br/>isNodeReady = true<br/>NOT in readyNodes (no active path)
OtherBranch->>OtherBranch: Ready to execute
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix conditional deactivation for loops/parallels
Type of Change
Testing
Tested with @icecrasher321
Checklist